This repository was archived by the owner on Feb 20, 2019. It is now read-only.
new method to check if a string is valid email id or not added#200
Open
souvikhaldar wants to merge 1 commit intoeggheadio-github:masterfrom
Open
new method to check if a string is valid email id or not added#200souvikhaldar wants to merge 1 commit intoeggheadio-github:masterfrom
souvikhaldar wants to merge 1 commit intoeggheadio-github:masterfrom
Conversation
kentcdodds
reviewed
Oct 24, 2018
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Hi @souvikhaldar! Could you fix the formatting to match the rest of the codebase and add a test like the other files have? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a method which checks for valid email ID using regular expression.